Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755484AbbBFOml (ORCPT ); Fri, 6 Feb 2015 09:42:41 -0500 Received: from mail-la0-f49.google.com ([209.85.215.49]:33851 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753295AbbBFOmj (ORCPT ); Fri, 6 Feb 2015 09:42:39 -0500 MIME-Version: 1.0 In-Reply-To: <1422977841-25036-3-git-send-email-gbroner@codeaurora.org> References: <1422977841-25036-1-git-send-email-gbroner@codeaurora.org> <1422977841-25036-3-git-send-email-gbroner@codeaurora.org> Date: Fri, 6 Feb 2015 23:42:36 +0900 Message-ID: Subject: Re: [PATCH v1 2/4] scsi: ufs: add debugfs for ufs From: Akinobu Mita To: Gilad Broner Cc: Jej B , LKML , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Yaniv Gardi , Dolev Raviv , Lee Susman , Raviv Shvili , Vinayak Holikatti , "James E.J. Bottomley" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 28 2015-02-04 0:37 GMT+09:00 Gilad Broner : > From: Lee Susman > > Adding debugfs capability for ufshcd. ... > +void ufsdbg_add_debugfs(struct ufs_hba *hba) > +{ > + if (!hba) { > + pr_err("%s: NULL hba, exiting\n", __func__); > + return; > + } > + > + hba->debugfs_files.debugfs_root = debugfs_create_dir("ufs", NULL); This creates "ufs" directory in the root of debugfs. So if there are two or more UFS host controllers on a single system, only the first one can succeed. Should we append the index for unique directory name for each contoroller like "ufs0", "ufs1", ...? MMC debugfs support does something similar, it creates "mmc0" directory in the root of debugfs. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/