Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755753AbbBFPHm (ORCPT ); Fri, 6 Feb 2015 10:07:42 -0500 Received: from mail-qa0-f51.google.com ([209.85.216.51]:44400 "EHLO mail-qa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbbBFPHl (ORCPT ); Fri, 6 Feb 2015 10:07:41 -0500 MIME-Version: 1.0 In-Reply-To: References: <1423234272-7348-1-git-send-email-chris@rorvick.com> <1423234272-7348-2-git-send-email-chris@rorvick.com> Date: Fri, 6 Feb 2015 09:07:40 -0600 X-Google-Sender-Auth: CjN7nWIiuIvZI4HBQx1a5H3YGTQ Message-ID: Subject: Re: [PATCH 1/4] ALSA: line6: Add toneport_has_source_select() From: Chris Rorvick To: Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Stefan Hajnoczi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 32 On Fri, Feb 6, 2015 at 8:56 AM, Takashi Iwai wrote: > At Fri, 6 Feb 2015 08:51:09 -0600, Chris Rorvick wrote: >> --- a/sound/usb/line6/toneport.c >> +++ b/sound/usb/line6/toneport.c >> @@ -343,6 +343,20 @@ static void toneport_remove_leds(struct usb_line6_toneport *toneport) >> } >> } >> >> +static bool toneport_has_source_select(struct usb_line6_toneport *toneport) >> +{ >> + switch (toneport->type) { >> + case LINE6_TONEPORT_UX1: >> + case LINE6_TONEPORT_UX2: >> + case LINE6_PODSTUDIO_UX1: >> + case LINE6_PODSTUDIO_UX2: >> + return 1; >> + >> + default: >> + return 0; > > Please use true and false. Thanks, I've fixed this up and will send in a v2. Regards, Chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/