Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756169AbbBFPlG (ORCPT ); Fri, 6 Feb 2015 10:41:06 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:63064 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754314AbbBFPlD (ORCPT ); Fri, 6 Feb 2015 10:41:03 -0500 MIME-Version: 1.0 In-Reply-To: References: <20150206060953.GA34087@dtor-ws> Date: Fri, 6 Feb 2015 16:41:02 +0100 X-Google-Sender-Auth: l-KXDIzQ5OboRBTz0rQ7lGN57Kw Message-ID: Subject: Re: [PATCH] Input: bfin_rotary - mark suspend and resume code as __maybe_unused From: Geert Uytterhoeven To: Sonic Zhang Cc: Dmitry Torokhov , Sonic Zhang , "linux-input@vger.kernel.org" , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1090 Lines: 29 On Fri, Feb 6, 2015 at 10:06 AM, Sonic Zhang wrote: >> static struct platform_driver bfin_rotary_device_driver = { >> .probe = bfin_rotary_probe, >> .remove = bfin_rotary_remove, >> .driver = { >> .name = "bfin-rotary", > > You missed > .owner = THIS_MODULE, > here. That line was removed in v3.19-rc1 by commit 776bd315a7721574 ("input: misc: drop owner assignment from platform_drivers"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/