MIME-Version: 1.0
In-Reply-To: <20150206115051.GL23123@twins.programming.kicks-ass.net>
References: <CA+55aFxNk9OCXz7nvKXpRBc0Z85NLXPNkRm1yJf4-KAGB4pHRA@mail.gmail.com>
	<1421878320.4903.17.camel@stgolabs.net>
	<54C02E08.4080405@hurleysoftware.com>
	<1861286.x5DC37NGWz@vostro.rjw.lan>
	<CA+55aFzWGCO16v3NL7SqgBnQQrwpwCTvFZR=+3x89Hg0KzJtxg@mail.gmail.com>
	<CA+55aFxYo1fpVoGVXhA0VPNAKKEZPAQDpF47pk+yPSnArvDEdA@mail.gmail.com>
	<20150205221436.01bc24f2@neptune.home>
	<20150206115051.GL23123@twins.programming.kicks-ass.net>
Date: Fri, 6 Feb 2015 08:02:41 -0800
Message-ID: <CA+55aFw21PK8gBMNk_7kp1MmJoEsRyvPx+qaXSgwLFX2UN793g@mail.gmail.com>
Subject: Re: Linux 3.19-rc5
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: =?UTF-8?Q?Bruno_Pr=C3=A9mont?= <bonbons@linux-vserver.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Hurley <peter@hurleysoftware.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ilya Dryomov <ilya.dryomov@inktank.com>,
        Mike Galbraith <umgwanakikbuti@gmail.com>,
        Oleg Nesterov <oleg@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1011
Lines: 27

On Fri, Feb 6, 2015 at 3:50 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> Also, set_current_state(TASK_RUNNING) is almost always pointless, nobody
> cares about that barrier, so make it go away.

I'd rather not mix this with the patch, and wonder if we should just
do that globally with some preprocessor magic. We do have a fair
number of "set_current_state(TASK_RUNNING)" and at least for the
*documented* reason for the memory barrier, all of them could/should
be barrier-less.

So something like

    if (__is_constant_p(state) && state == TASK_RUNNING)
        tsk->state = state;
    else
        set_mb(tsk->state, state);

might be more general solution than randomly doing one at a time when
changing code around it..

                         Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/