Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756968AbbBFQKQ (ORCPT ); Fri, 6 Feb 2015 11:10:16 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:54841 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755634AbbBFQKO (ORCPT ); Fri, 6 Feb 2015 11:10:14 -0500 Message-ID: <1423239007.3864.44.camel@pengutronix.de> Subject: Re: [PATCH v2 3/3] misc: sram: switch to ioremap_wc from ioremap From: Philipp Zabel To: Abhilash Kesavan Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, hirokazu.takata.wj@renesas.com, catalin.marinas@arm.com, Will.Deacon@arm.com, heiko@sntech.de, shc_work@mail.ru, nicoleotsuka@gmail.com, padma.v@samsung.com, arnd@arndb.de, alsa-devel@alsa-project.org, shawn.guo@linaro.org, bcousson@baylibre.com, tony@atomide.com, kernel@pengutronix.de, kgene@kernel.org Date: Fri, 06 Feb 2015 17:10:07 +0100 In-Reply-To: <1423230328-6721-4-git-send-email-a.kesavan@samsung.com> References: <1423230328-6721-1-git-send-email-a.kesavan@samsung.com> <1423230328-6721-4-git-send-email-a.kesavan@samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 24 Am Freitag, den 06.02.2015, 19:15 +0530 schrieb Abhilash Kesavan: > Currently, the SRAM allocator returns device memory via ioremap. > This causes issues on ARM64 when the internal SoC SRAM allocated by > the generic sram driver is used for audio playback. The destination > buffer address (which is ioremapped SRAM) is not 64-bit aligned for > certain streams (e.g. 44.1k sampling rate). In such cases we get > unhandled alignment faults. Use ioremap_wc in place of ioremap which > gives us normal non-cacheable memory instead of device memory. > > Signed-off-by: Abhilash Kesavan > Tested-by: Tony Lindgren > Tested-by: Heiko Stuebner Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/