Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbbBFT0l (ORCPT ); Fri, 6 Feb 2015 14:26:41 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:52759 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbbBFT0j (ORCPT ); Fri, 6 Feb 2015 14:26:39 -0500 Message-ID: <54D5154F.8080208@ti.com> Date: Fri, 6 Feb 2015 21:26:07 +0200 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Peter Zijlstra CC: Tony Lindgren , , , , , , Subject: Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning References: <1423226916-18804-1-git-send-email-peter.ujfalusi@ti.com> <20150206141346.GP21418@twins.programming.kicks-ass.net> <54D4E64C.7060208@ti.com> <20150206183205.GS21418@twins.programming.kicks-ass.net> In-Reply-To: <20150206183205.GS21418@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1417 Lines: 37 On 02/06/2015 08:32 PM, Peter Zijlstra wrote: > On Fri, Feb 06, 2015 at 06:05:32PM +0200, Peter Ujfalusi wrote: >> Certainly looks much simpler, but it adds quite a bit of data to the >> omap_hwmod struct, and we have a _lot_ of them for omap2plus configuration. >> >> ls -al vmlinux >> >> w/o any the lockdep warning fixes: >> 110109168 >> >> With my series applied: >> 110112031 (base + 2863) >> >> With setting individual lockdep class: >> 110114275 (base + 5107) >> >> I certainly like the lockdep_set_class() way since it is cleaner, but it adds >> almost double amount of bytes to the kernel. > > Yeah, I've never really bothered with data too much, its a debug > feature. So lock_class_key is 8 bytes, and strictly speaking you could > union them over other fields, all we really need is unique addresses, we > don't actually use the storage. True. our omap2plus defconfig does not have LOCKDEP enabled so it should not add anything to the data when running default kernel. I'll test the lockdep_set_class() method you suggested on Monday (not tomorrow), but still as first thing. If it is working as expected I'll send a patch with you as author. Thanks, P?ter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/