Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755906AbbBFUuj (ORCPT ); Fri, 6 Feb 2015 15:50:39 -0500 Received: from bhuna.collabora.co.uk ([93.93.135.160]:60322 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755692AbbBFUuh (ORCPT ); Fri, 6 Feb 2015 15:50:37 -0500 Message-ID: <54D52905.6040100@collabora.co.uk> Date: Fri, 06 Feb 2015 21:50:13 +0100 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Sergei Shtylyov , Kukjin Kim CC: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Andrzej Hajda , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Subject: Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs References: <1423244258-24314-1-git-send-email-javier.martinez@collabora.co.uk> <54D51170.10903@cogentembedded.com> In-Reply-To: <54D51170.10903@cogentembedded.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1447 Lines: 43 Hello Sergei, Thanks a lot for your feedback. On 02/06/2015 08:09 PM, Sergei Shtylyov wrote: > Hello. > > On 02/06/2015 08:37 PM, Javier Martinez Canillas wrote: > >> All the device nodes for the Exynos5420 power-domains have a quite >> generic "power-domain" name. > > And this is in conformance to the ePAPR standard. > True, I forgot that the ePAPR recommends that the node names should be somewhat generic but OTOH this is the only Exynos DTSI file that follows the standard for the power domain device nodes. All other Exynos DTSI use a prefix to differentiate between each power domain. >> So in case of an error, the Exynos PD >> driver shows the following (not very useful) message: > >> "Power domain power-domain disable failed" > > Why not fix the message instead to use the full device name? > Well, the full node name is also not very useful IMHO since you have to check the DTSI or SoC manual to map the device node unit-address to the corresponding power domain. I used $subject when debugging an HDMI issue and instead of dropping it, I just posted it in case someone considered useful. I don't really mind if the patch is nacked / not picked. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/