Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757101AbbBFVI6 (ORCPT ); Fri, 6 Feb 2015 16:08:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32856 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429AbbBFVI4 (ORCPT ); Fri, 6 Feb 2015 16:08:56 -0500 Date: Fri, 6 Feb 2015 22:07:38 +0100 From: Oleg Nesterov To: Linus Torvalds Cc: Konstantin Khlebnikov , Linux API , Andrew Morton , Linux Kernel Mailing List , Roman Gushchin , Nikita Vetoshkin , Pavel Emelyanov Subject: Re: [PATCH 2/2] kernel/fork: handle put_user errors for CLONE_PARENT_SETTID Message-ID: <20150206210738.GA18332@redhat.com> References: <20150206162301.18031.32251.stgit@buzz> <20150206162303.18031.37408.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 752 Lines: 24 I am not sure about these changes too, but On 02/06, Linus Torvalds wrote: > > What's the upside? If somebody passes in a bad pointer, it's their > problem. Yes. But unless I am totally confused (quite possible) this put_user() can fail even if the pointer is valid. So at least I think Konstantin has found a real problem. Which (I think) shoud be fixed, and this is not connected to fork. > insane with the whole "readable vs writable" thing. Agreed, this part doesn't look nice in any case. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/