MIME-Version: 1.0
In-Reply-To: <54D40DAF.4080609@codeaurora.org>
References: <1423092164-9145-1-git-send-email-gregory.0xf0@gmail.com> <54D40DAF.4080609@codeaurora.org>
From: Gregory Fong <gregory.0xf0@gmail.com>
Date: Fri, 6 Feb 2015 13:14:42 -0800
Message-ID: <CADtm3G7ROX4CrxSKRvTKcjqCiX=uJQZ=Q5izH8pS61z4jfumLg@mail.gmail.com>
Subject: Re: [PATCH] ARM: print cma-reserved pages from show_mem
To: Laura Abbott <lauraa@codeaurora.org>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Florian Fainelli <f.fainelli@gmail.com>, vishnu.ps@samsung.com,
        Russell King <linux@arm.linux.org.uk>, Nicolas Pitre <nico@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Yalin Wang <Yalin.Wang@sonymobile.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1818
Lines: 51

On Thu, Feb 5, 2015 at 4:41 PM, Laura Abbott <lauraa@codeaurora.org> wrote:
> On 2/4/2015 3:22 PM, Gregory Fong wrote:
>>
>> Add cma reserved information to the ARM-specific show_mem.  It was
>> added to the generic implementation by commit
>> 49abd8c28046adf77c5ce1949549aa64d7221881 "lib/show_mem.c: add cma
>> reserved information".
>>
>> Signed-off-by: Gregory Fong <gregory.0xf0@gmail.com>
>> ---
>>   arch/arm/mm/init.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
>> index 2495c8c..da77507 100644
>> --- a/arch/arm/mm/init.c
>> +++ b/arch/arm/mm/init.c
>> @@ -22,6 +22,7 @@
>>   #include <linux/memblock.h>
>>   #include <linux/dma-contiguous.h>
>>   #include <linux/sizes.h>
>> +#include <linux/cma.h>
>>
>>   #include <asm/cp15.h>
>>   #include <asm/mach-types.h>
>> @@ -130,6 +131,9 @@ void show_mem(unsigned int filter)
>>         printk("%d pages of RAM\n", total);
>>         printk("%d free pages\n", free);
>>         printk("%d reserved pages\n", reserved);
>> +#ifdef CONFIG_CMA
>> +       printk("%lu cma reserved pages\n", totalcma_pages);
>> +#endif
>
>
> Nit: 'cma reserved pages' is a bit unclear. Are there some CMA
> pages that aren't reserved? Dropping the reserved might be
> clearer.

Sure, I was trying to replicate what's in lib/show_mem.c, but it
doesn't actually make much sense.  Maybe it would be better to change
to "cma pages" here and change the wording in that lib/show_mem.c too.

I'll wait a bit for any other thoughts and send out a v2 with those changes.

Thanks,
Gregory
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/