Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757617AbbBFVQO (ORCPT ); Fri, 6 Feb 2015 16:16:14 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:28439 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753696AbbBFVQN (ORCPT ); Fri, 6 Feb 2015 16:16:13 -0500 Message-ID: <54D52EDC.9000602@oracle.com> Date: Fri, 06 Feb 2015 16:15:08 -0500 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Davidlohr Bueso , Linus Torvalds CC: Raghavendra K T , Thomas Gleixner , Ingo Molnar , Peter Anvin , Peter Zijlstra , Konrad Rzeszutek Wilk , Paolo Bonzini , Paul McKenney , Waiman Long , Dave Jones , Oleg Nesterov , the arch/x86 maintainers , Jeremy Fitzhardinge , Paul Gortmaker , Andi Kleen , Jason Wang , Linux Kernel Mailing List , KVM list , virtualization , xen-devel@lists.xenproject.org, Rik van Riel , Christian Borntraeger , Andrew Morton , Andrey Ryabinin Subject: Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions References: <1423234148-13886-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <1423251764.1057.1.camel@stgolabs.net> In-Reply-To: <1423251764.1057.1.camel@stgolabs.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1366 Lines: 34 On 02/06/2015 02:42 PM, Davidlohr Bueso wrote: > On Fri, 2015-02-06 at 08:25 -0800, Linus Torvalds wrote: >> On Fri, Feb 6, 2015 at 6:49 AM, Raghavendra K T >> wrote: >>> Paravirt spinlock clears slowpath flag after doing unlock. >> [ fix edited out ] >> >> So I'm not going to be applying this for 3.19, because it's much too >> late and the patch is too scary. Plus the bug probably effectively >> never shows up in real life (it is probably easy to trigger the >> speculative *read* but probably never the actual speculative write >> after dropping the lock last). >> >> This will need a lot of testing by the paravirt people - both >> performance and correctness. So *maybe* for 3.20, but maybe for even >> later, and then marked for stable, of course. >> >> Are there any good paravirt stress-tests that people could run for >> extended times? > > locktorture inside a VM should give a proper pounding. Would it catch lifetime issues too? I thought it just tests out correctness. I tried it and other unrelated stuff broke. I'll send separate mails for that... Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/