Date: Fri, 6 Feb 2015 19:08:27 -0800
From: Darren Hart <dvhart@infradead.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= 
	<giedrius.statkevicius@gmail.com>,
        Mattia Dongili <malattia@linux.it>,
        platform-driver-x86@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        David Miller <davem@davemloft.net>
Subject: Re: [PATCH] Sony-laptop: fix sparse warning
Message-ID: <20150207030827.GC20934@fury.dvhart.com>
References: <1423147781-26018-1-git-send-email-prabhakar.csengg@gmail.com>
 <54D39283.4070300@gmail.com>
 <CA+V-a8utKmCRLgWMEMSzPv01hQ5F_nXeyYQe5r9ZKiqTw_uddg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CA+V-a8utKmCRLgWMEMSzPv01hQ5F_nXeyYQe5r9ZKiqTw_uddg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1412
Lines: 43

On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote:
> Hi Giedrius,
> 
> On Thu, Feb 5, 2015 at 3:55 PM, Giedrius Statkevičius
> <giedrius.statkevicius@gmail.com> wrote:
> > On 2015.02.05 16:49, Lad Prabhakar wrote:
> >> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> >>
> >> this patch fixes following sparse warning:
> >>
> >> sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static?
> >>
> >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> > Don't put a comma between your first and last name, please. Also, is
> > this your real name and surname?
> >
> I have hundreds of patches with:
> 
> Lad, Prabhakar <prabhakar.lad@ti.com>
> Lad, Prabhakar <prabhakar.csengg@gmail.com>

I think there may be a problem with this in an unquoted email address. The
unquoted local part, per RFC 2822 3.4.1, can only contain  !#$%'*+-/=?^_`{|}~
and . separators.

David Miller is the one who usually catches this sort of thing. David, do we
have a problem here?

> 
> I don’t want to change it now! Yes that's my real name.
> 
> Cheers,
> --Prabhakar
> 

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/