Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755944AbbBGLeA (ORCPT ); Sat, 7 Feb 2015 06:34:00 -0500 Received: from canardo.mork.no ([148.122.252.1]:54911 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755490AbbBGLd6 convert rfc822-to-8bit (ORCPT ); Sat, 7 Feb 2015 06:33:58 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Darren Hart Cc: "Lad\, Prabhakar" , Giedrius =?utf-8?Q?St?= =?utf-8?Q?atkevi=C4=8Dius?= , Mattia Dongili , platform-driver-x86@vger.kernel.org, LKML , David Miller Subject: Re: [PATCH] Sony-laptop: fix sparse warning Organization: m References: <1423147781-26018-1-git-send-email-prabhakar.csengg@gmail.com> <54D39283.4070300@gmail.com> <20150207030827.GC20934@fury.dvhart.com> Date: Sat, 07 Feb 2015 12:33:16 +0100 In-Reply-To: <20150207030827.GC20934@fury.dvhart.com> (Darren Hart's message of "Fri, 6 Feb 2015 19:08:27 -0800") Message-ID: <87386irm6b.fsf@nemi.mork.no> User-Agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.3.9 (canardo.mork.no [IPv6:2001:4641::1]); Sat, 07 Feb 2015 12:33:17 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1710 Lines: 39 Darren Hart writes: > On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote: > >> Lad, Prabhakar >> Lad, Prabhakar > > I think there may be a problem with this in an unquoted email address. The > unquoted local part, per RFC 2822 3.4.1, can only contain !#$%'*+-/=?^_`{|}~ > and . separators. Yes, but that is not applicable to the git commit tags. They are not RFC2822 header fields. Nothing will ever parse "Lad" as an unqualified local destination in a SOB, and therefore there is no problem using the comma there. Note that names using non-ascii characters are often written without quotes i SOBs (wonder how I know this? :-). In practice I believe the character set is only limited by what you will allow in your git log. The only characters with a special meaning are :<>#, and the latter is somewhat dubious. But it's often used as a comment separator in stable CCs, so I guess it should be avoided for other uses. Scripts etc trying to parse these tags into email headers must be prepared to do the necessary stripping and quoting of any text outside the <> brackets. Requiring a full name is of course good for accountability, but do let people format their names as they want them to appear in the log. Different cultures have different traditions. Wookey has collected a few links on this subject if anyone is interested: http://wookware.org/name.html Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/