MIME-Version: 1.0
In-Reply-To: <20150206143250.GA21554@sudip-PC>
References: <1422557952-4209-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
	<20150205122745.GF5336@mwanda>
	<20150205124322.GA8137@sudip-PC>
	<20150205125124.GG5336@mwanda>
	<CAKXHbyNzzepKB9OQ_zDsErQOUEzXOJMYPvHHRX8nrvWr7+dMiw@mail.gmail.com>
	<20150206143250.GA21554@sudip-PC>
Date: Sat, 7 Feb 2015 14:04:58 +0100
Message-ID: <CAKXHbyP5HUq7SAkJ3bSwN==tSwbkoWdqH5YPjWz1htx5GxaGaA@mail.gmail.com>
Subject: Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null
 pointer dereference
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        Chaitanya Hazarey <c@24.io>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Donald <gdonald@gmail.com>, Koray Gulcu <koray.gulcu@ozu.edu.tr>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1436
Lines: 46

2015-02-06 15:32 GMT+01:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> On Thu, Feb 05, 2015 at 06:39:13PM +0100, Rickard Strandqvist wrote:
>> 2015-02-05 13:51 GMT+01:00 Dan Carpenter <dan.carpenter@oracle.com>:
>> > On Thu, Feb 05, 2015 at 06:13:22PM +0530, Sudip Mukherjee wrote:
>> >> if (driver_info) {
>> >>       stats->RxIs40MHzPacket = driver_info->BW;
>> >>       if (stats->RxDrvInfoSize != 0)
>> >>               TranslateRxSignalStuff819xUsb(skb, stats, driver_info);
>> >> }
>> >
>> > If driver_info is non-NULL then stats->RxDrvInfoSize is not zero and
>> > also the reverse.  So really you only need to test one.
>> >
>> > regards,
>> > dan carpenter
>> >
>>
>> True Dan
>>
>> Okay, I'll make one last patch then, or if you want to do it Sudip?
>> Have you not done before Saturday I do it.
> no, its yours. you found it so credit should be yours.
> I am sure Greg will accept this one. If he drops then maybe I can re-send with you as Reported-by
>
> regards
> Sudip
>
>>
>> Kind regards
>> Rickard Strandqvist


Thanks Sudip :)

And after checking some more, I agree with Dan cleaner to only use
if(driver_info)

New patch coming soon.

Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/