Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757696AbbBGP6J (ORCPT ); Sat, 7 Feb 2015 10:58:09 -0500 Received: from mail-oi0-f42.google.com ([209.85.218.42]:56343 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757220AbbBGP6H (ORCPT ); Sat, 7 Feb 2015 10:58:07 -0500 MIME-Version: 1.0 X-Originating-IP: [84.109.13.68] In-Reply-To: <20150206061837.GA66378@jaegeuk-mac02.hsd1.ca.comcast.net> References: <1422401503-4769-1-git-send-email-jaegeuk@kernel.org> <1422401503-4769-5-git-send-email-jaegeuk@kernel.org> <003b01d03bc0$a5f23d20$f1d6b760$@samsung.com> <20150129214117.GB17521@jaegeuk-mac02> <006701d03c4b$a62ec0c0$f28c4240$@samsung.com> <20150202232803.GB34575@jaegeuk-mac02.mot.com> <20150203024822.GA8798@lcm> <20150203200904.GA43329@jaegeuk-mac02.mot.com> <006001d04126$895e3680$9c1aa380$@samsung.com> <20150206061837.GA66378@jaegeuk-mac02.hsd1.ca.comcast.net> From: Leon Romanovsky Date: Sat, 7 Feb 2015 17:57:46 +0200 Message-ID: Subject: Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim To: Jaegeuk Kim Cc: Chao Yu , Linux-FSDevel , "linux-kernel@vger.kernel.org" , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 533 Lines: 12 Hi Jaegeuk, > + /* for batched trimming */ > + int trim_sections; /* # of sections to trim */ I would like to suggest to declare trim_sections variable as an unsigned int and not int, since it can't be negative by definition. What do you think about it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/