Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758430AbbBGRwF (ORCPT ); Sat, 7 Feb 2015 12:52:05 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:45747 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755887AbbBGRwD (ORCPT ); Sat, 7 Feb 2015 12:52:03 -0500 Message-ID: <54D650BF.5000400@cogentembedded.com> Date: Sat, 07 Feb 2015 20:51:59 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bas Peters , isdn@linux-pingi.de CC: julia.lawall@lip6.fr, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] drivers: isdn: act2000: capi.c: fix checkpatch errors References: <1423328797-17865-1-git-send-email-baspeters93@gmail.com> <1423328797-17865-3-git-send-email-baspeters93@gmail.com> In-Reply-To: <1423328797-17865-3-git-send-email-baspeters93@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1208 Lines: 38 Hello. On 02/07/2015 08:06 PM, Bas Peters wrote: > This patch fixes the following checkpatch errors: > 1. trailing statement > 1. assignment of variable in if condition > 1. incorrectly placed brace after function definition > Signed-off-by: Bas Peters > --- > drivers/isdn/act2000/capi.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > diff --git a/drivers/isdn/act2000/capi.c b/drivers/isdn/act2000/capi.c > index 3f66ca2..5d677e6 100644 > --- a/drivers/isdn/act2000/capi.c > +++ b/drivers/isdn/act2000/capi.c > @@ -113,7 +113,8 @@ actcapi_chkhdr(act2000_card *card, actcapi_msghdr *hdr) > m->hdr.cmd.cmd = c; \ > m->hdr.cmd.subcmd = s; \ > m->hdr.msgnum = actcapi_nextsmsg(card); \ > - } else m = NULL; \ > + } else > + m = NULL; \ Documentation/CodingStyle has an extra rule for such case: *else* branch should also have {} since *if* branch has {}. [...] WNR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/