Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932112AbbBGTFt (ORCPT ); Sat, 7 Feb 2015 14:05:49 -0500 Received: from mail-wi0-f170.google.com ([209.85.212.170]:56144 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757235AbbBGTFr (ORCPT ); Sat, 7 Feb 2015 14:05:47 -0500 From: Bas Peters To: isdn@linux-pingi.de Cc: julia.lawall@lip6.fr, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com, Bas Peters Subject: [PATCH 2/7] drivers: isdn: act2000: capi.c: fix checkpatch errors Date: Sat, 7 Feb 2015 20:05:24 +0100 Message-Id: <1423335929-24926-3-git-send-email-baspeters93@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1423335929-24926-1-git-send-email-baspeters93@gmail.com> References: <1423335929-24926-1-git-send-email-baspeters93@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1627 Lines: 52 This patch fixes the following checkpatch errors: 1. trailing statement 1. assignment of variable in if condition 1. incorrectly placed brace after function definition Signed-off-by: Bas Peters --- drivers/isdn/act2000/capi.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/act2000/capi.c b/drivers/isdn/act2000/capi.c index 3f66ca2..5d677e6 100644 --- a/drivers/isdn/act2000/capi.c +++ b/drivers/isdn/act2000/capi.c @@ -113,7 +113,8 @@ actcapi_chkhdr(act2000_card *card, actcapi_msghdr *hdr) m->hdr.cmd.cmd = c; \ m->hdr.cmd.subcmd = s; \ m->hdr.msgnum = actcapi_nextsmsg(card); \ - } else m = NULL; \ + } else + m = NULL; \ } #define ACTCAPI_CHKSKB if (!skb) { \ @@ -563,7 +564,8 @@ actcapi_data_b3_ind(act2000_card *card, struct sk_buff *skb) { blocknr = msg->msg.data_b3_ind.blocknr; skb_pull(skb, 19); card->interface.rcvcallb_skb(card->myid, chan, skb); - if (!(skb = alloc_skb(11, GFP_ATOMIC))) { + skb = alloc_skb(11, GFP_ATOMIC); + if (!skb) { printk(KERN_WARNING "actcapi: alloc_skb failed\n"); return 1; } @@ -990,7 +992,8 @@ actcapi_debug_dlpd(actcapi_dlpd *dlpd) } #ifdef DEBUG_DUMP_SKB -static void dump_skb(struct sk_buff *skb) { +static void dump_skb(struct sk_buff *skb) +{ char tmp[80]; char *p = skb->data; char *t = tmp; -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/