Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758712AbbBGTPZ (ORCPT ); Sat, 7 Feb 2015 14:15:25 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:48258 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755782AbbBGTPY (ORCPT ); Sat, 7 Feb 2015 14:15:24 -0500 X-IronPort-AV: E=Sophos;i="5.09,536,1418079600"; d="scan'208";a="99242741" Date: Sat, 7 Feb 2015 20:15:21 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Bas Peters cc: isdn@linux-pingi.de, julia.lawall@lip6.fr, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com Subject: Re: [PATCH 7/7] drivers: isdn: act2000: capi.c: add macro \ and fix brace In-Reply-To: <1423335929-24926-8-git-send-email-baspeters93@gmail.com> Message-ID: References: <1423335929-24926-1-git-send-email-baspeters93@gmail.com> <1423335929-24926-8-git-send-email-baspeters93@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 39 On Sat, 7 Feb 2015, Bas Peters wrote: > This patch adds the \ that was accidentally deleted in patch 2. It also adds a brace after the else statement, which is required due to the fact that the if statement has braces. You should fix the patch that was incorrect, rather than submitting a patch that does something incorrect and then another patch to fix it. The kernel should compile after every patch. julia > > --- > drivers/isdn/act2000/capi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/isdn/act2000/capi.c b/drivers/isdn/act2000/capi.c > index 5d677e6..0043b3c 100644 > --- a/drivers/isdn/act2000/capi.c > +++ b/drivers/isdn/act2000/capi.c > @@ -113,8 +113,9 @@ actcapi_chkhdr(act2000_card *card, actcapi_msghdr *hdr) > m->hdr.cmd.cmd = c; \ > m->hdr.cmd.subcmd = s; \ > m->hdr.msgnum = actcapi_nextsmsg(card); \ > - } else > + } else { \ > m = NULL; \ > + } \ > } > > #define ACTCAPI_CHKSKB if (!skb) { \ > -- > 2.1.0 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/