Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752480AbbBHGmY (ORCPT ); Sun, 8 Feb 2015 01:42:24 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47164 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752171AbbBHGmW (ORCPT ); Sun, 8 Feb 2015 01:42:22 -0500 Date: Sat, 07 Feb 2015 22:42:21 -0800 (PST) Message-Id: <20150207.224221.1054400171798732184.davem@davemloft.net> To: sowmini.varadhan@oracle.com Cc: chien.yen@oracle.com, rds-devel@oss.oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCHv2] rds: Make rds_message_copy_from_user() return 0 on success. From: David Miller In-Reply-To: <20150205224143.GD28883@oracle.com> References: <20150205220734.GC28883@oracle.com> <20150205222301.GU29656@ZenIV.linux.org.uk> <20150205224143.GD28883@oracle.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Feb 2015 22:42:21 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 17 From: Sowmini Varadhan Date: Thu, 5 Feb 2015 17:41:43 -0500 > Commit 083735f4b01b ("rds: switch rds_message_copy_from_user() to iov_iter") > breaks rds_message_copy_from_user() semantics on success, and causes it > to return nbytes copied, when it should return 0. This commit fixes that bug. > > Signed-off-by: Sowmini Varadhan > --- > changes from v1: incorporate Al.Viro comment. Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/