Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754855AbbBHJJb (ORCPT ); Sun, 8 Feb 2015 04:09:31 -0500 Received: from mout.gmx.net ([212.227.15.19]:64906 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbbBHJJ0 (ORCPT ); Sun, 8 Feb 2015 04:09:26 -0500 Date: Sun, 8 Feb 2015 11:11:38 +0200 From: Lauri Kasanen To: jkosina@suse.cz, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@gmail.com Cc: ao2@ao2.it, AndrewD207@aol.com Subject: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2 Message-Id: <20150208111138.6f562d6c.cand@gmx.com> X-Mailer: Sylpheed 3.1.4 (GTK+ 2.18.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:8amBc8AJWqdooO+E453OuUIQ+wfT2QAM6YvRSlmDW8Ml26I4w+V LVbFhcDjbJ3xEYLw39ZlapAD/MZ7XARar1jqILVgzNbPNe02IUukNsQasJdLvvuBqFII3s/ mJSbMEdZlEyg/5QihLTAodqsSYxCCYQDGS0u/akDByfzUF3FNa4CWxCgXfAGrpSYOgnkB95 UeWqwkMAGJUvwD13Xptsw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1920 Lines: 64 Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. v2: - edited error messages - use output_report cc: Antonio Ospite cc: Andrew Haines Signed-off-by: Lauri Kasanen --- drivers/hid/hid-sony.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) Despite Andrew's report, using output_report worked fine. diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index 31e9d25..2661227 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -1131,7 +1131,8 @@ static void sony_input_configured(struct hid_device *hdev, static int sixaxis_set_operational_usb(struct hid_device *hdev) { int ret; - char *buf = kmalloc(18, GFP_KERNEL); + char *buf = kmalloc(65, GFP_KERNEL); + unsigned char buf2[] = { 0x00 }; if (!buf) return -ENOMEM; @@ -1140,7 +1141,22 @@ static int sixaxis_set_operational_usb(struct hid_device *hdev) HID_REQ_GET_REPORT); if (ret < 0) - hid_err(hdev, "can't set operational mode\n"); + hid_err(hdev, "can't set operational mode: step 1\n"); + + /* + * Some compatible controllers like the Speedlink Strike FX and + * Gasia need another query plus an USB interrupt to get operational. + */ + ret = hid_hw_raw_request(hdev, 0xf5, buf, 64, HID_FEATURE_REPORT, + HID_REQ_GET_REPORT); + + if (ret < 0) + hid_err(hdev, "can't set operational mode: step 2\n"); + + ret = hid_hw_output_report(hdev, buf2, sizeof(buf2)); + + if (ret < 0) + hid_err(hdev, "can't set operational mode: step 3\n"); kfree(buf); -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/