Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756069AbbBHJz4 (ORCPT ); Sun, 8 Feb 2015 04:55:56 -0500 Received: from mout.web.de ([212.227.15.3]:51235 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbbBHJzy (ORCPT ); Sun, 8 Feb 2015 04:55:54 -0500 Message-ID: <54D7329C.206@users.sourceforge.net> Date: Sun, 08 Feb 2015 10:55:40 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mike Snitzer CC: Alasdair Kergon , Neil Brown , dm-devel@redhat.com, linux-raid@vger.kernel.org, Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 3/3] dm ioctl: Delete an unnecessary check before the function call "dm_table_destroy" References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54CF93BB.40206@users.sourceforge.net> <54CF9666.5060407@users.sourceforge.net> <20150206211234.GA14803@redhat.com> In-Reply-To: <20150206211234.GA14803@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Kq97OCtIoKBcBeJHt6w6U3i8EYhyUUYLq0kNB72rTz+mqM5p5Qm CKabVT7fE4Anvn2B+k7UAqnF42IlpHh7A8G+E/9BfAzEEOgSPkp0hlmHcWHnsGoWPFFhDB1 LPGSHzsT/qpxjKObW8d0xE8EMQBx4l3kdwITi30bNUSVJyDZzf8yFpJABMmMYl+yv9SodqZ WYdYSzbEtGV5946Bl75bg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 497 Lines: 14 > Your proposed patch (while technically correct) hurts code clarity. How many source code readability and understanding challenges does each additional condition check cause? Can the affected place become also a bit more efficient? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/