Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754573AbbBHLA3 (ORCPT ); Sun, 8 Feb 2015 06:00:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48799 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751924AbbBHLA2 (ORCPT ); Sun, 8 Feb 2015 06:00:28 -0500 Date: Sun, 8 Feb 2015 12:00:23 +0100 From: "Michael S. Tsirkin" To: Rusty Russell Cc: lkml Subject: Re: [PATCH 1/5] virtio: define VIRTIO_PCI_CAP_PCI_CFG in header. Message-ID: <20150208110023.GJ3185@redhat.com> References: <1423199216-2094-1-git-send-email-rusty@rustcorp.com.au> <1423199216-2094-2-git-send-email-rusty@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423199216-2094-2-git-send-email-rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1391 Lines: 39 On Fri, Feb 06, 2015 at 03:36:52PM +1030, Rusty Russell wrote: > This provides backdoor access to the device MMIOs, and every device should > have one. From the virtio 1.0 spec (CS03): > > 4.1.4.7.1 Device Requirements: PCI configuration access capability > > The device MUST present at least one VIRTIO_PCI_CAP_PCI_CFG capability. > > Signed-off-by: Rusty Russell Acked-by: Michael S. Tsirkin > --- > include/uapi/linux/virtio_pci.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > index 3b7e4d2765fb..75301468359f 100644 > --- a/include/uapi/linux/virtio_pci.h > +++ b/include/uapi/linux/virtio_pci.h > @@ -109,8 +109,10 @@ > #define VIRTIO_PCI_CAP_NOTIFY_CFG 2 > /* ISR access */ > #define VIRTIO_PCI_CAP_ISR_CFG 3 > -/* Device specific confiuration */ > +/* Device specific configuration */ > #define VIRTIO_PCI_CAP_DEVICE_CFG 4 > +/* PCI configuration access */ > +#define VIRTIO_PCI_CAP_PCI_CFG 5 > > /* This is the PCI capability header: */ > struct virtio_pci_cap { > -- > 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/