Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754640AbbBHLP0 (ORCPT ); Sun, 8 Feb 2015 06:15:26 -0500 Received: from mail-la0-f54.google.com ([209.85.215.54]:43142 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbbBHLPY (ORCPT ); Sun, 8 Feb 2015 06:15:24 -0500 Message-ID: <54D74548.4020602@cogentembedded.com> Date: Sun, 08 Feb 2015 14:15:20 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bas Peters , gregkh@linuxgoundation.org, stern@rowland.harvard.edu CC: dan.j.williams@intel.com, hdegoede@redhat.com, sarah.a.sharp@linux.intel.com, peter.chen@freescale.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] drivers: usb: core: hcd.c: remove assignment of variables in if conditions. References: <1423346106-13493-1-git-send-email-baspeters93@gmail.com> <1423346106-13493-4-git-send-email-baspeters93@gmail.com> In-Reply-To: <1423346106-13493-4-git-send-email-baspeters93@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 38 Hello. On 2/8/2015 12:55 AM, Bas Peters wrote: > This patch removes assignment of variables in if conditions, > as specified in CodingStyle. > Signed-off-by: Bas Peters > --- > drivers/usb/core/hcd.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > index 11cee55..37c40d1 100644 > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c [...] > @@ -2733,7 +2736,8 @@ int usb_add_hcd(struct usb_hcd *hcd, > /* "reset" is misnamed; its role is now one-time init. the controller > * should already have been reset (and boot firmware kicked off etc). > */ > - if (hcd->driver->reset && (retval = hcd->driver->reset(hcd)) < 0) { > + retval = hcd->driver->reset(hcd); This will crash if 'hcd->driver->reset' is NULL (which is only checked below). > + if (hcd->driver->reset && retval < 0) { It wasn't equivalent change anyway as the right part of && is only executed if the left part is true. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/