Message-ID: <54D74664.2050307@cogentembedded.com>
Date: Sun, 08 Feb 2015 14:20:04 +0300
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Bas Peters <baspeters93@gmail.com>, gregkh@linuxgoundation.org,
        stern@rowland.harvard.edu
CC: dan.j.williams@intel.com, hdegoede@redhat.com,
        sarah.a.sharp@linux.intel.com, peter.chen@freescale.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] drivers: usb: core: hub.c: remove assignment of variables
 in if conditions.
References: <1423346106-13493-1-git-send-email-baspeters93@gmail.com> <1423346106-13493-6-git-send-email-baspeters93@gmail.com>
In-Reply-To: <1423346106-13493-6-git-send-email-baspeters93@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 947
Lines: 32

On 2/8/2015 12:55 AM, Bas Peters wrote:

> As specified in the CodingStyle.

> Signed-off-by: Bas Peters <baspeters93@gmail.com>
> ---
>   drivers/usb/core/hub.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)

> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 82983d9..9afe8b0 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -671,8 +671,8 @@ resubmit:
>   	if (hub->quiescing)
>   		return;
>
> -	if ((status = usb_submit_urb (hub->urb, GFP_ATOMIC)) != 0
> -			&& status != -ENODEV && status != -EPERM)
> +	status = usb_submit_urb (hub->urb, GFP_ATOMIC);

    checkpatch.pl should also complain about space before (.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/