Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755079AbbBHLYt (ORCPT ); Sun, 8 Feb 2015 06:24:49 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:53309 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbbBHLYr (ORCPT ); Sun, 8 Feb 2015 06:24:47 -0500 Message-ID: <54D7477C.7010603@cogentembedded.com> Date: Sun, 08 Feb 2015 14:24:44 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bas Peters , mdharm-usb@one-eyed-alien.net, gregkh@linuxfoundation.org CC: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drivers: usb: storage: cypress_atacb.c: trivial checkpatch fixes References: <1423348964-23882-1-git-send-email-baspeters93@gmail.com> <1423348964-23882-3-git-send-email-baspeters93@gmail.com> In-Reply-To: <1423348964-23882-3-git-send-email-baspeters93@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1436 Lines: 47 On 2/8/2015 1:42 AM, Bas Peters wrote: > Fixes errors thrown by checkpatch over a space issue and the > incorrect indentation of a switch statement. > Signed-off-by: Bas Peters > --- > drivers/usb/storage/cypress_atacb.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > diff --git a/drivers/usb/storage/cypress_atacb.c b/drivers/usb/storage/cypress_atacb.c > index 8514a2d..b3466d1 100644 > --- a/drivers/usb/storage/cypress_atacb.c > +++ b/drivers/usb/storage/cypress_atacb.c > @@ -96,13 +96,13 @@ static void cypress_atacb_passthrough(struct scsi_cmnd *srb, struct us_data *us) > if (save_cmnd[1] >> 5) /* MULTIPLE_COUNT */ > goto invalid_fld; > /* check protocol */ > - switch((save_cmnd[1] >> 1) & 0xf) { > - case 3: /*no DATA */ > - case 4: /* PIO in */ > - case 5: /* PIO out */ > - break; > - default: > - goto invalid_fld; > + switch ((save_cmnd[1] >> 1) & 0xf) { > + case 3: /*no DATA */ Could also add space after /*, while at it. > + case 4: /* PIO in */ > + case 5: /* PIO out */ > + break; > + default: > + goto invalid_fld; > } > > /* first build the ATACB command */ [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/