Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756616AbbBHONO (ORCPT ); Sun, 8 Feb 2015 09:13:14 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:40154 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbbBHONM (ORCPT ); Sun, 8 Feb 2015 09:13:12 -0500 Date: Sun, 8 Feb 2015 23:12:46 +0900 From: Namhyung Kim To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Jiri Olsa , Arnaldo Carvalho de Melo , Masami Hiramatsu Subject: Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs Message-ID: <20150208141246.GA13586@danjae> References: <20150202193501.962297539@goodmis.org> <20150202193553.340946602@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150202193553.340946602@goodmis.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2755 Lines: 73 Hi Steve, On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > As tracefs may be mounted instead of debugfs to get to the event directories, > have perf know about tracefs, and use that file system over debugfs if it > is present. > > Signed-off-by: Steven Rostedt > --- > tools/perf/tests/open-syscall-all-cpus.c | 7 +++- > tools/perf/tests/open-syscall.c | 7 +++- > tools/perf/tests/parse-events.c | 13 +++++-- > tools/perf/util/cache.h | 1 + > tools/perf/util/evlist.c | 1 - > tools/perf/util/parse-events.h | 2 +- > tools/perf/util/probe-event.c | 24 ++++++++----- > tools/perf/util/util.c | 60 ++++++++++++++++++++++++++------ > tools/perf/util/util.h | 1 + > 9 files changed, 91 insertions(+), 25 deletions(-) > > diff --git a/tools/perf/tests/open-syscall-all-cpus.c b/tools/perf/tests/open-syscall-all-cpus.c > index 8fa82d1700c7..21969e99ea46 100644 > --- a/tools/perf/tests/open-syscall-all-cpus.c > +++ b/tools/perf/tests/open-syscall-all-cpus.c > @@ -29,7 +29,12 @@ int test__open_syscall_event_on_all_cpus(void) > > evsel = perf_evsel__newtp("syscalls", "sys_enter_open"); > if (evsel == NULL) { > - pr_debug("is debugfs mounted on /sys/kernel/debug?\n"); > + if (tracefs_configured()) > + pr_debug("is tracefs mounted on /sys/kernel/debug?\n"); Shouldn't it be /sys/kernel/tracing/ ? > + else if (debugfs_configured()) > + pr_debug("is debugfs mounted on /sys/kernel/debug?\n"); > + else > + pr_debug("Neither tracefs or debugfs is enabled in this kernel\n"); > goto out_thread_map_delete; > } > > diff --git a/tools/perf/tests/open-syscall.c b/tools/perf/tests/open-syscall.c > index a33b2daae40f..4250e40234d2 100644 > --- a/tools/perf/tests/open-syscall.c > +++ b/tools/perf/tests/open-syscall.c > @@ -18,7 +18,12 @@ int test__open_syscall_event(void) > > evsel = perf_evsel__newtp("syscalls", "sys_enter_open"); > if (evsel == NULL) { > - pr_debug("is debugfs mounted on /sys/kernel/debug?\n"); > + if (tracefs_configured()) > + pr_debug("is tracefs mounted on /sys/kernel/debug?\n"); Ditto. Thanks, Namhyung > + else if (debugfs_configured()) > + pr_debug("is debugfs mounted on /sys/kernel/debug?\n"); > + else > + pr_debug("Neither tracefs or debugfs is enabled in this kernel\n"); > goto out_thread_map_delete; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/