Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759018AbbBHWrD (ORCPT ); Sun, 8 Feb 2015 17:47:03 -0500 Received: from mail-wg0-f43.google.com ([74.125.82.43]:53518 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943AbbBHWrB (ORCPT ); Sun, 8 Feb 2015 17:47:01 -0500 Date: Sun, 8 Feb 2015 22:46:57 +0000 From: Luis de Bethencourt To: linux-media@vger.kernel.org Cc: crope@iki.fi, mchehab@osg.samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtl2832: remove compiler warning Message-ID: <20150208224657.GA22793@turing> References: <20150208224422.GA22749@turing> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150208224422.GA22749@turing> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1448 Lines: 43 On Sun, Feb 08, 2015 at 10:44:22PM +0000, Luis de Bethencourt wrote: > Cleaning the following compiler warning: > rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function > > Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set > tmp, this line would never run because we go to err. It is still nice to avoid > compiler warnings. > > Signed-off-by: Luis de Bethencourt > --- > drivers/media/dvb-frontends/rtl2832.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c > index 5d2d8f4..ad36d1c 100644 > --- a/drivers/media/dvb-frontends/rtl2832.c > +++ b/drivers/media/dvb-frontends/rtl2832.c > @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status) > struct rtl2832_dev *dev = fe->demodulator_priv; > struct i2c_client *client = dev->client; > int ret; > - u32 tmp; > + u32 tmp = 0; > > dev_dbg(&client->dev, "\n"); > > -- > 2.1.0 > Hello all :) This warning can be seen in: http://hverkuil.home.xs4all.nl/logs/Saturday.log Thank you Hans for the daily build and logs. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/