Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759158AbbBIB0M (ORCPT ); Sun, 8 Feb 2015 20:26:12 -0500 Received: from mga03.intel.com ([134.134.136.65]:55837 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758995AbbBIB0L (ORCPT ); Sun, 8 Feb 2015 20:26:11 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,540,1418112000"; d="asc'?scan'208";a="524533135" Message-ID: <1423445167.2589.167.camel@jtkirshe-mobl> Subject: Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210 From: Jeff Kirsher To: Nicholas Krause Cc: linux.nics@intel.com, e1000-devel@lists.sourceforge.net, bruce.w.allan@intel.com, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, john.ronciak@intel.com, netdev@vger.kernel.org Date: Sun, 08 Feb 2015 17:26:07 -0800 In-Reply-To: <1423444889.2589.165.camel@jtkirshe-mobl> References: <1423372910-29183-1-git-send-email-xerofoify@gmail.com> <1423444889.2589.165.camel@jtkirshe-mobl> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-J73cGSNGILhDp5LIpquu" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2464 Lines: 63 --=-J73cGSNGILhDp5LIpquu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2015-02-08 at 17:21 -0800, Jeff Kirsher wrote: > On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote: > > Removes the outdated fix me comment in the > > function,gb_acquire_swfw_sync_i210 > > for setting the variables, i and timeout to the intended correct > > values for > > the function,gb_acquire_swfw_sync_i210 to function correctly. This > > comment is > > no longer due to these values having been no changed in the last few > > years and > > no known issues have been found for these variables being set to their > > current > > values. Due to this the comment can now be removed as the values set > > for these > > variables are known to be correct after years of no known issues or > > bugs related > > to their current values. > >=20 > > Signed-off-by: Nicholas Krause > > --- > > drivers/net/ethernet/intel/igb/e1000_i210.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > Thank Nick, I will add your patch to my queue. Oh and the title should be "igb: Remove outdated ...", not "net:ethernet:intel: Remove ..." --=-J73cGSNGILhDp5LIpquu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJU2AyvAAoJEOVv75VaS+3OP1AP/10eAvPDJRsjXNBx0JAm/fmP 60q4EiIFxDyjKF6I28rWql0tUoHksw58jExWp11SG2jaGeGTM0u3QUjXvCQwrKMO 2Sn9deUhOTsd9YI9JSHN+CHpHNSTVtY+LCJ+eMaP6qYH+rOD8eqWc54m9mG29Qdy 9sGZSV8c9hl7T9zyKUM4dkG00RQi5j8SMNX3p3j892keE3oUuY/MChuc152a1HCF sM3wxqHObW6uZ8/MqMPBtFR3uJ1dVI9EH2g0P5J7cqNwJDVjGASQID4FMLKW+Kvp /GkxOvIlJjSEwNnius2SbKtTH16u8qQAxV3fg/WshpK/uYGBE6SU2dGXx9l8ay/U YWY4Lj3K2GFfPlJw/wwyZuBATabAMGpu+YFsif38xO+OpWAMT3icAbJ98dHy7im5 mdq96+aM9T/snF4CC9wazlOmn6lq5V0AzhoJYmrUDSZeCXES2A2ByCGQzAk9g98s c0BYK0LpcEI67BJspWqo7sB+CHsUVrSAT1b3+UkGmU4WLIR0Cxq12L08lrlfTv1w cJWfu3X8yK3G8bXuc/Dkjx4vQYAonLNxt1w7/NiHT6AgOamB0Y2IH34JxIVGBjLL cbPJ3R3kQpKl8jkXavtXRkocyQXUaR6gyph77SylKqIwjbY22vErGeBeCxeNUJ4Y /V7OTV2upjpwAKFIi3VO =Api8 -----END PGP SIGNATURE----- --=-J73cGSNGILhDp5LIpquu-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/