Message-ID: <54D85AC0.70000@gmail.com>
Date: Mon, 09 Feb 2015 14:59:12 +0800
From: Peter Hung <hpeter@gmail.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, johan@kernel.org
CC: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
        peter_hong@fintek.com.tw, Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V5 6/8] USB: f81232: clarify f81232_ioctl()
References: <1423216014-571-1-git-send-email-hpeter+linux_kernel@gmail.com> <1423216014-571-7-git-send-email-hpeter+linux_kernel@gmail.com> <54D4B1B3.60001@cogentembedded.com>
In-Reply-To: <54D4B1B3.60001@cogentembedded.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1230
Lines: 41

Hello,

Sergei Shtylyov 於 2015/2/6 下午 08:21 寫道:
>> We extract TIOCGSERIAL section in f81232_ioctl() to
>> f81232_get_serial_info()
>> to make it clarify
>
>     You're also changing 'ser.baud_rate' from 460800 to 115200. And
> explicitly overriding some previously initialized to 0 fields.

F81232 max baudrate is only 115200bps, so I set it for
1.8432MHz/16 = 115200.

We had add some closing time referenced from serial_core.c. The default
value is:

port->close_delay     = HZ / 2;	/* .5 seconds */
port->closing_wait    = 30 * HZ;/* 30 seconds */

We had increasing close_delay about 10x to

port->close_delay     = 5 * HZ ;

>
>> The f81232_set_mctrl() replace set_control_lines() to do MCR control
>> so we clean-up the set_control_lines() function.
>
>     I don't see where are you doing this...
>

This text is my patch V5 5/8 second section. I had wrong operation of 
copy & paste. It's doesn't need for this patch, sorry for it.

-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/