Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759467AbbBIHEN (ORCPT ); Mon, 9 Feb 2015 02:04:13 -0500 Received: from mail.kernel.org ([198.145.29.136]:41150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752414AbbBIHEL (ORCPT ); Mon, 9 Feb 2015 02:04:11 -0500 Date: Sun, 8 Feb 2015 23:04:12 -0800 From: Jaegeuk Kim To: Leon Romanovsky Cc: Chao Yu , Linux-FSDevel , "linux-kernel@vger.kernel.org" , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim Message-ID: <20150209070412.GA72988@jaegeuk-mac02.hsd1.ca.comcast.net> References: <1422401503-4769-5-git-send-email-jaegeuk@kernel.org> <003b01d03bc0$a5f23d20$f1d6b760$@samsung.com> <20150129214117.GB17521@jaegeuk-mac02> <006701d03c4b$a62ec0c0$f28c4240$@samsung.com> <20150202232803.GB34575@jaegeuk-mac02.mot.com> <20150203024822.GA8798@lcm> <20150203200904.GA43329@jaegeuk-mac02.mot.com> <006001d04126$895e3680$9c1aa380$@samsung.com> <20150206061837.GA66378@jaegeuk-mac02.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 21 On Sat, Feb 07, 2015 at 05:57:46PM +0200, Leon Romanovsky wrote: > Hi Jaegeuk, > > > + /* for batched trimming */ > > + int trim_sections; /* # of sections to trim */ > I would like to suggest to declare trim_sections variable as an > unsigned int and not int, since it can't be negative by definition. > What do you think about it? Hi Leon, No problem. :) I'll change that and merge the patch. Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/