Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759624AbbBIHbz (ORCPT ); Mon, 9 Feb 2015 02:31:55 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:32237 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759502AbbBIHby (ORCPT ); Mon, 9 Feb 2015 02:31:54 -0500 Date: Mon, 9 Feb 2015 10:31:45 +0300 From: Dan Carpenter To: Tal Shorer Cc: "Drokin, Oleg" , "" , "Dilger, Andreas" , "" , "" , "" , "" Subject: Re: [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c Message-ID: <20150209073145.GD5206@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 701 Lines: 23 On Sun, Feb 08, 2015 at 07:57:01PM +0200, Tal Shorer wrote: > Signed-off-by: Tal Shorer > --- > Decided not to #define the constants away because their addresses are > used later in the file. I don't understand what this means. > 1) The subject is crap (which coding style issues are you fixing). 2) The subject is too long. 3) Don't put the whole path in the subject. 4) There is no patch description. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/