Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932423AbbBIIC4 (ORCPT ); Mon, 9 Feb 2015 03:02:56 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:38478 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392AbbBIICz (ORCPT ); Mon, 9 Feb 2015 03:02:55 -0500 X-ME-Helo: beldin X-ME-Date: Mon, 09 Feb 2015 09:02:53 +0100 X-ME-IP: 109.220.218.8 From: Robert Jarzmik To: Alexandre Courbot Cc: Tyler Hall , "linux-gpio\@vger.kernel.org" , "devicetree\@vger.kernel.org" , Daniel Mack , Hans Holmberg , Linus Walleij , Linux Kernel Mailing List , Howard Cochran Subject: Re: gpio-pxa: getting GPIOs by devicetree phandle broken References: X-URL: http://belgarath.falguerolles.org/ Date: Mon, 09 Feb 2015 09:02:51 +0100 In-Reply-To: (Alexandre Courbot's message of "Mon, 9 Feb 2015 15:11:23 +0900") Message-ID: <87r3tz7bro.fsf@free.fr> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1428 Lines: 40 Alexandre Courbot writes: > Adding Robert who reported the same thing. > > On Sat, Feb 7, 2015 at 6:28 AM, Tyler Hall wrote: >> 1. Require child nodes in DT for each bank > > This would break DT compatibility. Agreed. > >> 2. Refactor gpio-pxa to only register one gpiochip > > Sounds better, especially since this would reflect the hardware more > accurately. One DT node should translate into one GPIO chip. Could I know where "should translate into _one_ GPIO chip" comes from ? Is it a specification, or is it a new rule we're creating ? And if it's a new rule, I'd like to know what backs it up . > problem is that I'm afraid several other drivers are doing the same > thing and thus are now similarly broken. That's also what I'm afraid of. > The following is also likely to work as a workaround, but I would not > go as far as saying this should be taken as a fix. Hans, since you > wrote 7b8792b, could we have your input on this? I was going to suggest the very same approach. If this one (or a similar one) doesn't meet success, then my weekend of revert queries is not over ... and I don't like reverts. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/