Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759925AbbBIIXO (ORCPT ); Mon, 9 Feb 2015 03:23:14 -0500 Received: from mga03.intel.com ([134.134.136.65]:31944 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759483AbbBIIXM (ORCPT ); Mon, 9 Feb 2015 03:23:12 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,542,1418112000"; d="scan'208";a="663567484" Message-ID: <54D86E2D.8010808@linux.intel.com> Date: Mon, 09 Feb 2015 16:22:05 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org CC: riel@redhat.com, mtosatti@redhat.com, rkrcmar@redhat.com, jan.kiszka@siemens.com, dmatlack@google.com Subject: Re: [PATCH] kvm: add halt_poll_ns module parameter References: <1423226937-11169-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1423226937-11169-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 26 On 02/06/2015 08:48 PM, Paolo Bonzini wrote: > > +unsigned int halt_poll_ns = 0; > +module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR); > + Can we make this parameter be changeable? So that we can tune it on the fly. > finish_wait(&vcpu->wq, &wait); > + cur = ktime_get(); We can move this into the tracepoint to avoid the workload if the tracepoint is not enabled. Otherwise looks good to me. Reviewed-by: Xiao Guangrong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/