Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S265099AbTAEUpI>; Sun, 5 Jan 2003 15:45:08 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S265097AbTAEUpI>; Sun, 5 Jan 2003 15:45:08 -0500
Received: from modemcable092.130-200-24.mtl.mc.videotron.ca ([24.200.130.92]:29358
	"EHLO montezuma.mastecende.com") by vger.kernel.org with ESMTP
	id <S265085AbTAEUpH>; Sun, 5 Jan 2003 15:45:07 -0500
Date: Sun, 5 Jan 2003 15:54:46 -0500 (EST)
From: Zwane Mwaikambo <zwane@holomorphy.com>
X-X-Sender: zwane@montezuma.mastecende.com
To: Andries.Brouwer@cwi.nl
cc: mdharm-kernel@one-eyed-alien.net, "" <linux-kernel@vger.kernel.org>,
       "" <linux-scsi@vger.kernel.org>,
       "" <linux-usb-devel@lists.sourceforge.net>
Subject: Re: inquiry in scsi_scan.c
In-Reply-To: <UTC200301051307.h05D7da08203.aeb@smtp.cwi.nl>
Message-ID: <Pine.LNX.4.50.0301051548150.15466-100000@montezuma.mastecende.com>
References: <UTC200301051307.h05D7da08203.aeb@smtp.cwi.nl>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1448
Lines: 38

On Sun, 5 Jan 2003 Andries.Brouwer@cwi.nl wrote:

> The SCSI code has no means of knowing the actual length transferred,
> so has no choice but to believe the length byte in the reply.
> But the USB code does the transferring itself, and knows precisely
> how many bytes were transferred. If 36 bytes were transferred and
> the additional length byte is 0, indicating a length of 5, then the
> USB code can fix the response and change the additional length byte
> to 31, indicating a length of 36. That way the SCSI code knows that
> not 5 but 36 bytes are valid, and it gets actual vendor and model strings.

This looks related to something i also bumped into;

scsi scan: host 2 channel 0 id 0 lun 0 identifier too long, length 60, max
50. Device might be improperly identified.

The 'HBA' is idescsi with a memorex cdrw with an inquiry returning a
length value of 34

scsi_check_fill_deviceid:
...
	if (scsi_check_id_size(sdev, 26 + id_page[3]))

I wrote up an ugly hack to truncate the length in idescsi_transform_pc2,
but i don't know SCSI and it doesn't seem right.

> [the code I showed does the right things; will submit actual diffs
> sooner or later]

Thanks,
	Zwane
-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/