Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760085AbbBIJaE (ORCPT ); Mon, 9 Feb 2015 04:30:04 -0500 Received: from canardo.mork.no ([148.122.252.1]:42484 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759711AbbBIJaB convert rfc822-to-8bit (ORCPT ); Mon, 9 Feb 2015 04:30:01 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Jeff Kirsher Cc: Andrej Manduch , Nicholas Krause , jesse.brandeburg@intel.com, bruce.w.allan@intel.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, gregory.v.rose@intel.com, matthew.vick@intel.com, john.ronciak@intel.com, mitch.a.williams@intel.com, linux.nics@intel.com, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function,gb_acquire_swfw_sync_i210 Organization: m References: <1423372910-29183-1-git-send-email-xerofoify@gmail.com> <1423444889.2589.165.camel@jtkirshe-mobl> <54D85EFA.3020501@gmail.com> <1423470722.27854.11.camel@jtkirshe-mobl> Date: Mon, 09 Feb 2015 10:29:35 +0100 In-Reply-To: <1423470722.27854.11.camel@jtkirshe-mobl> (Jeff Kirsher's message of "Mon, 09 Feb 2015 00:32:02 -0800") Message-ID: <87egpzqvpc.fsf@nemi.mork.no> User-Agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.3.9 (canardo.mork.no [IPv6:2001:4641::1]); Mon, 09 Feb 2015 10:29:42 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 31 Jeff Kirsher writes: > If you want to see Nick's patch, feel free to view his patch on > my queue tree: > https://git.kernel.org/cgit/linux/kernel/git/jkirsher/queue.git/ which said: - s32 i = 0, timeout = 200; /* FIXME: find real value to use here */ + s32 i = 0, timeout = 200; Comments like the one deleted by that patch do have some value in my opinion: They document that the constant is chosen arbitrarily and is not taken from some datasheet. Not a big deal, but leaving such comments, even if the value never ever changes, could save someone from trying to figure out where the heck you got that constant. And there's noone actually misinterpreting this comment as "something needs to be fixed here", is there? So the cost of leaving the comment is exactly zero. Just my .02 €. I'm not going to tell you how to maintain your driver, of course. At least I try not to :-) Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/