Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932953AbbBIKIX (ORCPT ); Mon, 9 Feb 2015 05:08:23 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40002 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932286AbbBIKIU (ORCPT ); Mon, 9 Feb 2015 05:08:20 -0500 Message-ID: <1423476481.10695.2.camel@linux-0dmf.site> Subject: Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers From: Oliver Neukum To: Lauri Kasanen Cc: jkosina@suse.cz, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ao2@ao2.it, AndrewD207@aol.com Date: Mon, 09 Feb 2015 11:08:01 +0100 In-Reply-To: <20150207154859.89a7e4e3.cand@gmx.com> References: <20150207154859.89a7e4e3.cand@gmx.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2712 Lines: 78 On Sat, 2015-02-07 at 15:48 +0200, Lauri Kasanen wrote: > Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send > any events. Now everything works including the leds. > > Based on work by Andrew Haines and Antonio Ospite. > > cc: Antonio Ospite > cc: Andrew Haines > Signed-off-by: Lauri Kasanen > --- > drivers/hid/hid-sony.c | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > Antonio's original approach was not enough; it enabled the events, > but only for a few seconds, then the controller timed out and sent > no more. Andrew's did more than was necessary. This is a combination > of the two, against Linus' git. > > diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c > index 31e9d25..de93386 100644 > --- a/drivers/hid/hid-sony.c > +++ b/drivers/hid/hid-sony.c > @@ -36,6 +36,7 @@ > #include > #include > #include > +#include > > #include "hid-ids.h" > > @@ -1130,8 +1131,12 @@ static void sony_input_configured(struct hid_device *hdev, > */ > static int sixaxis_set_operational_usb(struct hid_device *hdev) > { > + struct usb_interface *intf = to_usb_interface(hdev->dev.parent); > + struct usb_device *dev = interface_to_usbdev(intf); > int ret; > - char *buf = kmalloc(18, GFP_KERNEL); > + char *buf = kmalloc(65, GFP_KERNEL); > + unsigned char buf2[] = { 0x00 }; > + int transfered; > > if (!buf) > return -ENOMEM; > @@ -1140,7 +1145,24 @@ static int sixaxis_set_operational_usb(struct hid_device *hdev) > HID_REQ_GET_REPORT); > > if (ret < 0) > - hid_err(hdev, "can't set operational mode\n"); > + hid_err(hdev, "can't set operational mode on the control EP\n"); > + > + /* > + * Some compatible controllers like the Speedlink Strike FX and > + * Gasia need another query plus an USB interrupt to get operational. > + */ > + ret = hid_hw_raw_request(hdev, 0xf5, buf, 64, HID_FEATURE_REPORT, > + HID_REQ_GET_REPORT); > + > + if (ret < 0) > + hid_err(hdev, "can't set operational mode on the interrupt EP\n"); > + > + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), > + buf2, sizeof(buf2), > + &transfered, USB_CTRL_SET_TIMEOUT); You cannot do this. Even for a single byte DMA on the stack is wrong. Not on all architectures it works at all and you violate the DMA constrainsts. You must use kmalloc(). Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/