Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933090AbbBIKKU (ORCPT ); Mon, 9 Feb 2015 05:10:20 -0500 Received: from mail-ie0-f180.google.com ([209.85.223.180]:45567 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932326AbbBIKKS (ORCPT ); Mon, 9 Feb 2015 05:10:18 -0500 MIME-Version: 1.0 In-Reply-To: <54D74548.4020602@cogentembedded.com> References: <1423346106-13493-1-git-send-email-baspeters93@gmail.com> <1423346106-13493-4-git-send-email-baspeters93@gmail.com> <54D74548.4020602@cogentembedded.com> Date: Mon, 9 Feb 2015 11:10:12 +0100 Message-ID: Subject: Re: [PATCH 3/6] drivers: usb: core: hcd.c: remove assignment of variables in if conditions. From: Bas Peters To: Sergei Shtylyov Cc: gregkh@linuxgoundation.org, Alan Stern , dan.j.williams@intel.com, hdegoede@redhat.com, sarah.a.sharp@linux.intel.com, Peter Chen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 56 2015-02-08 12:15 GMT+01:00 Sergei Shtylyov : > Hello. > > On 2/8/2015 12:55 AM, Bas Peters wrote: > >> This patch removes assignment of variables in if conditions, >> as specified in CodingStyle. > > >> Signed-off-by: Bas Peters >> --- >> drivers/usb/core/hcd.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) > > >> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c >> index 11cee55..37c40d1 100644 >> --- a/drivers/usb/core/hcd.c >> +++ b/drivers/usb/core/hcd.c > > [...] >> >> @@ -2733,7 +2736,8 @@ int usb_add_hcd(struct usb_hcd *hcd, >> /* "reset" is misnamed; its role is now one-time init. the >> controller >> * should already have been reset (and boot firmware kicked off >> etc). >> */ >> - if (hcd->driver->reset && (retval = hcd->driver->reset(hcd)) < 0) >> { >> + retval = hcd->driver->reset(hcd); > > > This will crash if 'hcd->driver->reset' is NULL (which is only checked > below). > >> + if (hcd->driver->reset && retval < 0) { > > > It wasn't equivalent change anyway as the right part of && is only > executed if the left part is true. I'll fix this and your other comments and resend. > > WBR, Sergei > With kind regards, Bas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/