Date: Mon, 9 Feb 2015 12:01:49 +0100
From: Borislav Petkov <bp@suse.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: "Luck, Tony" <tony.luck@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-edac@kernel.org
Subject: Re: [GIT PULL] RAS update for 3.20 (one more thing)
Message-ID: <20150209110149.GC4051@pd.tnic>
References: <54cfb6e332538eb6ea@agluck-desk.sc.intel.com>
 <20150209101316.GB5461@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150209101316.GB5461@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1467
Lines: 38

On Mon, Feb 09, 2015 at 11:13:16AM +0100, Ingo Molnar wrote:
> This kind of vendor specific hard coding is really ugly:
> 
>         if (c->x86_vendor == X86_VENDOR_AMD && ret == NOTIFY_STOP)
>                 return;

Yeah, I raised the same concern but we already have a bunch of vendor
checks in mce.c anyway so one more shouldn't hurt.

> Instead we should fix the Intel side to do a proper decode 
> as well - by the time mcelog is running it might be too 
> late, attempting an intelligent printk is way better...
> 
> So what would we need to make the Intel side just as good 
> as the AMD side?

The only thing that needs to be done is actually code it, methinks.
Once that's done, we would finally carry ready and decoded information
through a tracepoint to userspace instead of the /dev/mcelog thing.

I'm afraid this won't happen quickly though so we probably would need
this fix for the interim while we're working on the decoding.

Both sides (AMD/Intel) would need to be taught to funnel the decoded
strings through a tracepoint - something which we've talked about in the
past but keeps getting pushed down the TODO list. :-\

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/