Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759422AbbBILWg (ORCPT ); Mon, 9 Feb 2015 06:22:36 -0500 Received: from mail-qc0-f173.google.com ([209.85.216.173]:33688 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682AbbBILWf (ORCPT ); Mon, 9 Feb 2015 06:22:35 -0500 MIME-Version: 1.0 In-Reply-To: <1423480761-33453-1-git-send-email-tfiga@chromium.org> References: <1423480761-33453-1-git-send-email-tfiga@chromium.org> From: Tomasz Figa Date: Mon, 9 Feb 2015 20:22:12 +0900 Message-ID: Subject: Re: [PATCH] CHROMIUM: iommu: rockchip: Make sure that page table state is coherent To: iommu@lists.linux-foundation.org Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Joerg Roedel , Heiko Stuebner , Daniel Kurtz , Tomasz Figa Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 861 Lines: 19 On Mon, Feb 9, 2015 at 8:19 PM, Tomasz Figa wrote: > Even though the code uses the dt_lock spin lock to serialize mapping > operation from different threads, it does not protect from IOMMU > accesses that might be already taking place and thus altering state > of the IOTLB. This means that current mapping code which first zaps > the page table and only then updates it with new mapping which is > prone to mentioned race. Oops, forgot to remove the "CHROMIUM" tag. Is that something that could be fixed when applying (if the patch is otherwise okay) or should I resend? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/