Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759809AbbBILoI (ORCPT ); Mon, 9 Feb 2015 06:44:08 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:45380 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbbBILoG (ORCPT ); Mon, 9 Feb 2015 06:44:06 -0500 Date: Mon, 9 Feb 2015 12:44:03 +0100 From: Sascha Hauer To: Russell King - ARM Linux Cc: James Liao , Mike Turquette , YH Chen =?utf-8?B?KOmZs+aYseixqik=?= , linux-kernel@vger.kernel.org, Henry Chen , Rob Herring , kernel@pengutronix.de, Matthias Brugger , Yingjoe Chen =?utf-8?B?KOmZs+iLsea0sik=?= , Eddie Huang , Lee Jones , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 09/13] ARM: dts: mediatek: Enable clock support for Mediatek MT8135. Message-ID: <20150209114403.GV12209@pengutronix.de> References: <1423478845-2835-1-git-send-email-s.hauer@pengutronix.de> <1423478845-2835-10-git-send-email-s.hauer@pengutronix.de> <20150209105134.GF8656@n2100.arm.linux.org.uk> <20150209112500.GU12209@pengutronix.de> <20150209112721.GG8656@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150209112721.GG8656@n2100.arm.linux.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:32:20 up 116 days, 22:46, 168 users, load average: 0.00, 0.02, 0.05 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1978 Lines: 52 On Mon, Feb 09, 2015 at 11:27:21AM +0000, Russell King - ARM Linux wrote: > On Mon, Feb 09, 2015 at 12:25:00PM +0100, Sascha Hauer wrote: > > On Mon, Feb 09, 2015 at 10:51:34AM +0000, Russell King - ARM Linux wrote: > > > On Mon, Feb 09, 2015 at 11:47:21AM +0100, Sascha Hauer wrote: > > > > From: James Liao > > > > > > > > This patch adds MT8135 clock controllers into device tree. > > > > @@ -86,6 +87,18 @@ > > > > clock-frequency = <32000>; > > > > #clock-cells = <0>; > > > > }; > > > > + > > > > + clk_null: clk_null { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <0>; > > > > + }; > > > > + > > > > + clk26m: clk26m { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <26000000>; > > > > + }; > > > > > > Is this supposed to be here? > > > > The clock support needs at least the clk26m clk. Do you think it should > > be in another patch or not present at all? > > I didn't see anything which referenced either clk_null or clk26m in this > patch. My main concern was that clk_null, but my concern grew when I > found that clk26m wasn't referenced either. > > If the MT8135 needs it, shouldn't something in its description reference > this clock? It's used in the code. The mt8135 clk code directly uses the names of these three clocks as parent_names. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/