Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932954AbbBIOZY (ORCPT ); Mon, 9 Feb 2015 09:25:24 -0500 Received: from mail-wi0-f181.google.com ([209.85.212.181]:33935 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932352AbbBIOZW (ORCPT ); Mon, 9 Feb 2015 09:25:22 -0500 MIME-Version: 1.0 In-Reply-To: <20150209125548.GA27277@linuxteamdev.amer.dell.com> References: <20150209125548.GA27277@linuxteamdev.amer.dell.com> From: "Lad, Prabhakar" Date: Mon, 9 Feb 2015 14:24:50 +0000 Message-ID: Subject: Re: [PATCH] Trivial patch in efifb.c to solve common indent issue and indent error To: Parmeshwr Prasad Cc: pjones@redhat.com, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , LFBDEV , LKML , linux-efi@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 37 Hi, Thanks for the patch. On Mon, Feb 9, 2015 at 12:55 PM, Parmeshwr Prasad wrote: > Hi All, > > Please review this patch. > this patch is aimed to solve some indentation issue. It has also solved > three trivial error in efifb.c file. > > And I have also changed printk with pr_err, pr_info ... at respective places. > > > From c49139fac1d15fe2da80d06e2a79eb8be7c079a7 Mon Sep 17 00:00:00 2001 > From: Parmeshwr Prasad > Date: Mon, 9 Feb 2015 07:33:59 -0500 > Subject: [PATCH] Trival patch: improved indentation, and removed some ERROR > from code > > Signed-off-by: Parmeshwr Prasad > --- 1: did you use git to send this patch ? 2: did you checkpatch it (I see some issues)? 3: break this patch into 2 one fixing the 3 issues and other fixing the indentation. 4: have proper commit message. Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/