Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760863AbbBIPdl (ORCPT ); Mon, 9 Feb 2015 10:33:41 -0500 Received: from mail-la0-f41.google.com ([209.85.215.41]:35356 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760551AbbBIPdj (ORCPT ); Mon, 9 Feb 2015 10:33:39 -0500 MIME-Version: 1.0 In-Reply-To: <20150209132313.65f6b3e3.m.chehab@samsung.com> References: <1423137035-16506-1-git-send-email-bp@alien8.de> <20150205123716.GF23980@pd.tnic> <20150208181916.GB6290@pd.tnic> <20150209121717.GD24769@pd.tnic> <20150209142058.GC20645@redhat.com> <20150209132313.65f6b3e3.m.chehab@samsung.com> From: Andy Lutomirski Date: Mon, 9 Feb 2015 07:33:17 -0800 Message-ID: Subject: Re: [PATCH] sb_edac: Fix detection on SNB machines To: Mauro Carvalho Chehab Cc: Aristeu Rozanski , Borislav Petkov , "linux-kernel@vger.kernel.org" , Tony Luck , linux-edac Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1217 Lines: 31 On Mon, Feb 9, 2015 at 7:23 AM, Mauro Carvalho Chehab wrote: > Em Mon, 09 Feb 2015 09:20:58 -0500 > Aristeu Rozanski escreveu: > >> On Mon, Feb 09, 2015 at 01:17:17PM +0100, Borislav Petkov wrote: >> > From: Borislav Petkov >> > Subject: [PATCH] sb_edac: Fix detection on SNB machines >> > >> > d0585cd815fa ("sb_edac: Claim a different PCI device") changed the >> > probing of sb_edac to look for PCI device 0x3ca0: >> > >> > 3f:0e.0 System peripheral: Intel Corporation Xeon E5/Core i7 Processor Home Agent (rev 07) >> > 00: 86 80 a0 3c 00 00 00 00 07 00 80 08 00 00 80 00 >> > ... >> > >> > but we're matching for 0x3ca8, i.e. PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_TA >> > in sbridge_probe() therefore the probing fails. >> > >> > Changing it to probe for 0x3ca0 (PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_HA0), >> > .i.e., the 14.0 device, fixes the issue and driver loads successfully >> > again: Looks good to me, too. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/