Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933398AbbBIP6o (ORCPT ); Mon, 9 Feb 2015 10:58:44 -0500 Received: from netrider.rowland.org ([192.131.102.5]:56753 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933240AbbBIP6m (ORCPT ); Mon, 9 Feb 2015 10:58:42 -0500 Date: Mon, 9 Feb 2015 10:58:41 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Amit Daniel Kachhap cc: linux-pm@vger.kernel.org, , , , , , , , , , , , , , Subject: Re: [PATCH RFC v4 1/3] PM / Runtime: Add an API pm_runtime_set_slave In-Reply-To: <1423479726-23140-2-git-send-email-amit.daniel@samsung.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1237 Lines: 35 On Mon, 9 Feb 2015, Amit Daniel Kachhap wrote: > This API creates a pm runtime slave type device which does not itself > participates in pm runtime but depends on the master devices to power > manage them. This makes no sense. How can a master device manage a slave device? Devices are managed by drivers, not by other devices. > These devices should have pm runtime callbacks. > > These devices (like clock) may not implement complete pm_runtime calls > such as pm_runtime_get/pm_runtime_put due to subsystems interaction > behaviour or any other reason. > > Signed-off-by: Amit Daniel Kachhap > --- > drivers/base/power/runtime.c | 18 ++++++++++++++++++ > include/linux/pm.h | 1 + > include/linux/pm_runtime.h | 2 ++ > 3 files changed, 21 insertions(+) This patch is unacceptable because it does not update the runtime PM documentation file. Besides, doesn't the no_callbacks flag already do more or less what you want? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/