Date: Mon, 9 Feb 2015 09:03:54 -0800 (PST)
From: Hisashi T Fujinaka <htodd@twofifty.com>
To: =?ISO-8859-15?Q?Bj=F8rn_Mork?= <bjorn@mork.no>
cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>, linux.nics@intel.com,
        e1000-devel@lists.sourceforge.net, bruce.w.allan@intel.com,
        jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
        john.ronciak@intel.com, netdev@vger.kernel.org,
        Andrej Manduch <amanduch@gmail.com>
Subject: Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me
 comment in the function, gb_acquire_swfw_sync_i210
In-Reply-To: <87egpzqvpc.fsf@nemi.mork.no>
Message-ID: <alpine.NEB.2.11.1502090901440.395@chris.i8u.org>
References: <1423372910-29183-1-git-send-email-xerofoify@gmail.com> <1423444889.2589.165.camel@jtkirshe-mobl> <54D85EFA.3020501@gmail.com> <1423470722.27854.11.camel@jtkirshe-mobl> <87egpzqvpc.fsf@nemi.mork.no>
User-Agent: Alpine 2.11 (NEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1520
Lines: 37

On Mon, 9 Feb 2015, Bj?rn Mork wrote:

> Jeff Kirsher <jeffrey.t.kirsher@intel.com> writes:
>
>> If you want to see Nick's patch, feel free to view his patch on
>> my queue tree:
>> https://git.kernel.org/cgit/linux/kernel/git/jkirsher/queue.git/
>
> which said:
>  - s32 i = 0, timeout = 200; /* FIXME: find real value to use here */
>  + s32 i = 0, timeout = 200;
>
>
> Comments like the one deleted by that patch do have some value in my
> opinion: They document that the constant is chosen arbitrarily and is
> not taken from some datasheet.
>
> Not a big deal, but leaving such comments, even if the value never ever
> changes, could save someone from trying to figure out where the heck you
> got that constant.  And there's noone actually misinterpreting this
> comment as "something needs to be fixed here", is there? So the cost of
> leaving the comment is exactly zero.
>
> Just my .02 ?.  I'm not going to tell you how to maintain your driver,
> of course.  At least I try not to :-)

I think, for now, we should NAK this. It's a short comment and you don't
want me to replace it with a philosophical statement on how you could
tune the timeout. That's what the data sheet is for.

(Replying from my home account and not my work account -
todd.fujinaka@intel.com)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/