Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933814AbbBISmD (ORCPT ); Mon, 9 Feb 2015 13:42:03 -0500 Received: from mout.gmx.net ([212.227.15.18]:49227 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933415AbbBISmB (ORCPT ); Mon, 9 Feb 2015 13:42:01 -0500 Date: Mon, 9 Feb 2015 20:44:14 +0200 From: Lauri Kasanen To: Oliver Neukum Cc: jkosina@suse.cz, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ao2@ao2.it, AndrewD207@aol.com Subject: Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers Message-Id: <20150209204414.a4d205be.cand@gmx.com> In-Reply-To: <1423476481.10695.2.camel@linux-0dmf.site> References: <20150207154859.89a7e4e3.cand@gmx.com> <1423476481.10695.2.camel@linux-0dmf.site> X-Mailer: Sylpheed 3.1.4 (GTK+ 2.18.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:rBxa8zsK8qhVwC/8KjyH8tBAkZRNZb+kh1wFINSSlB3LhZ+w6Yh qdao+BbxYs9YG50/9HYcOdxSQdhYbV3LdhB8AP+Vwk8GV49aRXuQxRiQPi540DN1RNqClt1 YMMWeJcgxD+Aga2YWRSSyEBv6/pqv4OFk+Ud7rRSzCj13qo+EQXwDT//6WtVMDnyFZZOkYP F6VbDGWZHa2htCr7c4DEQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 715 Lines: 21 On Mon, 09 Feb 2015 11:08:01 +0100 Oliver Neukum wrote: > > + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), > > + buf2, sizeof(buf2), > > + &transfered, USB_CTRL_SET_TIMEOUT); > > You cannot do this. Even for a single byte DMA on the stack is > wrong. Not on all architectures it works at all and you violate > the DMA constrainsts. You must use kmalloc(). Hi Oliver, Does this still apply when using hid_hw_output_report? - Lauri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/