Date: Tue, 10 Feb 2015 05:34:08 +0800
From: "<gregkh@linuxfoundation.org>" <gregkh@linuxfoundation.org>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        "<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
        "Dilger, Andreas" <andreas.dilger@intel.com>,
        "<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
        "Drokin, Oleg" <oleg.drokin@intel.com>,
        "<clabbe.montjoie@gmail.com>" <clabbe.montjoie@gmail.com>
Subject: Re: [PATCH v3] staging: lustre: fix coding style errors
Message-ID: <20150209213408.GA11071@kroah.com>
References: <CAFDyS3P2Fbg4kawfs7dVOUhc71P8yC2jssjTpzGJFbdfcca1HA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFDyS3P2Fbg4kawfs7dVOUhc71P8yC2jssjTpzGJFbdfcca1HA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 883
Lines: 24

On Mon, Feb 09, 2015 at 07:20:30PM +0200, Tal Shorer wrote:
> Fix the following coding style errors in
> drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
> 1. initializing lnet_table_header (static pointer) to NULL
> 2. missing spaces around '='

Those are two different things, and should be 2 different patches.
Please split up and resend that way.

> There's a third coding style error in this file which I've chosen to
> not fix for clarity's sake. It is: initializing min_watchdog_ratelimit
> (static int) to 0

Please fix that too, it's not correct.  Drop the comment there if you
think that's confusing.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/