Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761461AbbBIVkU (ORCPT ); Mon, 9 Feb 2015 16:40:20 -0500 Received: from senator.holtmann.net ([87.106.208.187]:43578 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761222AbbBIVkS convert rfc822-to-8bit (ORCPT ); Mon, 9 Feb 2015 16:40:18 -0500 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: [PATCH v3] net: bluetooth: hci_sock: Use 'const u32 *' instead of 'void *' for 2nd parameter of hci_test_bit() From: Marcel Holtmann In-Reply-To: <54D9290A.8070306@sunrus.com.cn> Date: Mon, 9 Feb 2015 13:40:09 -0800 Cc: David Laight , Joe Perches , Sergei Shtylyov , "Gustavo F. Padovan" , Johan Hedberg , "David S. Miller" , "linux-bluetooth@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Content-Transfer-Encoding: 8BIT Message-Id: References: <54D61229.9010904@sunrus.com.cn> <1423338774.2933.9.camel@perches.com> <54D6A729.1070905@sunrus.com.cn> <54D75698.7010808@sunrus.com.cn> <54D82D7D.3000308@sunrus.com.cn> <063D6719AE5E284EB5DD2968C1650D6D1CAE0823@AcuExch.aculab.com> <063D6719AE5E284EB5DD2968C1650D6D1CAE0B02@AcuExch.aculab.com> <54D9290A.8070306@sunrus.com.cn> To: Chen Gang S X-Mailer: Apple Mail (2.2070.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1878 Lines: 44 Hi Chen, >>>>> So at present, in kernel part, we can only say the original authors >>>>> intended to do like this. And only within kernel part, it can not cause >>>>> issue. I guess, original authors originally knew what we talk about. >>>> >>>> I've just searched for hci_u*filter it is all horrid. >>>> Look at the code for get/set_sockopt of HCI_FILTER. >>>> Someone seems to have done a complete 'bodge job' of fixing the user interface >>>> for apps (32bit and 64bit) on 64bit kernels. >>> >>> we are actually fully aware of that. Just keep in mind that this code is from 2.4.6 kernel and with >>> that most likely 14 years old by now. Unfortunately it ended up as userspace API. >> >> AFAICT the userspace API is always __u32[2] the long[2] is never exposed >> to userspace (certainly not through the socket option code). >> >> Quite why all the casts were added - instead of changing the type >> is probably hidden in the annals of the source repo. >> Some serious archaeology might be in order. >> > > For me, I guess what you said above sounds reasonable. But excuse me, > I am not familiar with the related modules outside Linux kernel (at > present, it is out of my border). > > I guess, I am not the suitable member to make the related fix patch for > this issue. Welcome any other members to send the fix patch for it. > > And for me, if "hci_u*filter" is related with the modules outside kernel > (I guess, it should be), I recommend to put it to the related "uapi" > header. since that is such old code, the "uapi" is essentially what we have as libbluetooth from the BlueZ userspace code. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/