Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761281AbbBIV4F (ORCPT ); Mon, 9 Feb 2015 16:56:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55759 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755796AbbBIV4D (ORCPT ); Mon, 9 Feb 2015 16:56:03 -0500 Date: Tue, 10 Feb 2015 05:55:59 +0800 From: Greg Kroah-Hartman To: "Fu, Zhonghui" Cc: "rjw@rjwysocki.net >> Rafael J. Wysocki" , pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] PM-Trace: add pm-trace support for suspending phase Message-ID: <20150209215559.GA12087@kroah.com> References: <54D8318B.2060703@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54D8318B.2060703@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2001 Lines: 56 On Mon, Feb 09, 2015 at 12:03:23PM +0800, Fu, Zhonghui wrote: > >From ec9c0f24e800461361eaf8b280abe4272b00772d Mon Sep 17 00:00:00 2001 > From: Zhonghui Fu > Date: Mon, 9 Feb 2015 11:09:22 +0800 > Subject: [PATCH] PM-Trace: add pm-trace support for suspending phase Why is this crud here? > > Occasinally, the system can't come back up after suspend/resume > due to problems of device suspending phase. This patch make > PM_TRACE infrastructure cover device suspending phase of > suspend/resume process, and the information in RTC can tell > develpers which device suspending function make system hang. > > Signed-off-by: Zhonghui Fu > --- > arch/x86/include/asm/resume-trace.h | 2 +- > drivers/base/power/main.c | 30 +++++++++++++++++++++--------- > include/linux/resume-trace.h | 2 +- > 3 files changed, 23 insertions(+), 11 deletions(-) > > diff --git a/arch/x86/include/asm/resume-trace.h b/arch/x86/include/asm/resume-trace.h > index 3ff1c2c..0ca2215 100644 > --- a/arch/x86/include/asm/resume-trace.h > +++ b/arch/x86/include/asm/resume-trace.h > @@ -3,7 +3,7 @@ > > #include > > -#define TRACE_RESUME(user) \ > +#define TRACE_SUSPEND_RESUME(user) \ > do { \ > if (pm_trace_enabled) { \ > const void *tracedata; \ Why rename this? If you want to do that, do it in 2 different functions (rename first, with justification, add new functionality in a second patch) > @@ -1078,7 +1082,7 @@ static int device_suspend_noirq(struct device *dev) > { > reinit_completion(&dev->power.completion); > > - if (pm_async_enabled && dev->power.async_suspend) { > + if (is_async(dev)) { Why change this logic? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/