Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932890AbbBIXeC (ORCPT ); Mon, 9 Feb 2015 18:34:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34896 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761535AbbBIXeA (ORCPT ); Mon, 9 Feb 2015 18:34:00 -0500 Message-ID: <54D943E6.1030404@codeaurora.org> Date: Mon, 09 Feb 2015 15:33:58 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Vikram Mulukutla , Steven Rostedt , Ingo Molnar CC: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Lime Yang Subject: Re: [PATCH] tracing: Fix unmapping loop in tracing_mark_write References: <1418871056-6614-1-git-send-email-markivx@codeaurora.org> In-Reply-To: <1418871056-6614-1-git-send-email-markivx@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 44 On 12/17/14 18:50, Vikram Mulukutla wrote: > Commit 6edb2a8a385f0cdef51dae37ff23e74d76d8a6ce introduced > an array map_pages that contains the addresses returned by > kmap_atomic. However, when unmapping those pages, map_pages[0] > is unmapped before map_pages[1], breaking the nesting requirement > as specified in the documentation for kmap_atomic/kunmap_atomic. > > This was caught by the highmem debug code present in kunmap_atomic. > Fix the loop to do the unmapping properly. > > Reviewed-by: Stephen Boyd > Reported-by: Lime Yang > Signed-off-by: Vikram Mulukutla > --- ping? What happened to this patch? > kernel/trace/trace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index ab76b7b..bceed34 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -4931,7 +4931,7 @@ tracing_mark_write(struct file *filp, const char __user *ubuf, > *fpos += written; > > out_unlock: > - for (i = 0; i < nr_pages; i++){ > + for (i = nr_pages - 1; i >= 0; i--) { > kunmap_atomic(map_page[i]); > put_page(pages[i]); > } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/