Message-ID: <54D96E6D.4000205@gmail.com>
Date: Tue, 10 Feb 2015 10:35:25 +0800
From: Peter Hung <hpeter@gmail.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Johan Hovold <johan@kernel.org>
CC: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
        peter_hong@fintek.com.tw, Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V5 6/8] USB: f81232: clarify f81232_ioctl()
References: <1423216014-571-1-git-send-email-hpeter+linux_kernel@gmail.com> <1423216014-571-7-git-send-email-hpeter+linux_kernel@gmail.com> <54D4B1B3.60001@cogentembedded.com> <54D85AC0.70000@gmail.com> <20150209084240.GA10150@localhost>
In-Reply-To: <20150209084240.GA10150@localhost>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 884
Lines: 29

Hello,

Johan Hovold 於 2015/2/9 下午 04:42 寫道:

> The value you should be returning is
> jiffies_to_msecs(port->port.closing_wait) / 10, unless the value is
> ASYNC_CLOSING_WAIT_NONE in which case you simply return that, and
> similarly for close_delay.

I'll try to fix it, or reuse default value next version.

> Make sure to update the commit log for the next revision so that it
> describes what you actually do.
>
> I will probably not have time to review this version this week I'm
> afraid.

OK, I'll review it again, fix and resend it after Chinese New Year (2/23+).

Thanks all seniors.

-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/