Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761956AbbBJE7M (ORCPT ); Mon, 9 Feb 2015 23:59:12 -0500 Received: from mail-wg0-f50.google.com ([74.125.82.50]:49041 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbbBJE7L (ORCPT ); Mon, 9 Feb 2015 23:59:11 -0500 MIME-Version: 1.0 In-Reply-To: <20150210042237.GD37927@fury.dvhart.com> References: <1423540502-3214-1-git-send-email-coproscefalo@gmail.com> <20150210042237.GD37927@fury.dvhart.com> Date: Mon, 9 Feb 2015 21:59:09 -0700 Message-ID: Subject: Re: [PATCH v2] toshiba_acpi: Make toshiba_eco_mode_available more robust From: Azael Avalos To: Darren Hart Cc: "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 46 Hi Darren, 2015-02-09 21:22 GMT-07:00 Darren Hart : > On Mon, Feb 09, 2015 at 08:55:02PM -0700, Azael Avalos wrote: >> Some Toshiba laptops do not come with the ECO led installed, however, >> the driver is registering support for it when it should not. >> >> This patch makes the toshiba_eco_mode_available function more robust >> in detecting ECO led capabilities, not registering the led on laptops >> that do not support it and registering the led when it really does. >> >> The ECO led function now returns 0x8e00 (Not Installed) by querying >> with in[3] = 0, whenever theres no physical LED installed, and >> returning 0x8300 (Input Data Error) when it is, however, there are >> some BIOSes that have stub function calls not returning anything and >> and the LED device was being registered too, hence the change of the >> default return value from 1 to 0. >> >> Signed-off-by: Azael Avalos > > Careful with whitespace errors caught by checkpatch. Fixed that and corrected a minor > grammatical issue in the comment block - since I was late in reviewing ;-) Apologies for that, between my bit of dyslexia (I tend to switch numbers and letters) and my bad English... Good thing I'm not working at a bank or stock exchange ;-) > > Applied and queued, thanks. > > -- > Darren Hart > Intel Open Source Technology Center Cheers Azael -- -- El mundo apesta y vosotros apestais tambien -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/